[MERGE] Speed up diff spec handling.

John Arbash Meinel john at arbash-meinel.com
Fri Apr 25 19:49:56 BST 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Aaron Bentley wrote:
| John Arbash Meinel wrote:
|> I would rather it provide a branch location than fetch. So if it can be
|> (a) or (b), then I would chose (a).
|
| If you were the one writing the code, I would cheer you on.
|
| But this is significant scope creep, because branch locations on
| RevisionSpecs are a newer interface that is frequently ignored.  I think
| there are many callers who still assume that any revision-id returned is
| in the context of the default branch.


Good enough, I guess. If there are tons of tests that fail with this activated,
then not a big deal. We still have revisions specs which are broken in those
cases, but ....

So I'm pretty sure that makes this approved. Not voting because BB doesn't like
it when I vote far down in a thread.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkgSJ9MACgkQJdeBCYSNAAOzrgCfbaaqyeD/7KHn2ALSx7ndcS7f
FykAoJSlfy76bjZs9lvZm5mtfhuDJ4rS
=/t7N
-----END PGP SIGNATURE-----



More information about the bazaar mailing list