[BzrTools/MERGE] cdiff --check-style Highlight trailing white space

[raindog at macrohmasheen.com]

This is a little off topic, but, what's the deal with 80 character line limits? My *cell phone* csn displsy more text than that.
Sent from my Verizon Wireless BlackBerry

-----Original Message-----
From: "Marius Kruger" <amanic at gmail.com>

Date: Sun, 20 Apr 2008 02:07:28 
To:"Aaron Bentley" <aaron.bentley at utoronto.ca>
Cc:Bazaar <bazaar at lists.canonical.com>
Subject: [BzrTools/MERGE] cdiff --check-style Highlight trailing white space


I finally got time to look at this again, 
(I got tired of merging my changes in locally every time I update.)

On Wed, Jan 17, 2007 at 6:48 PM, Aaron Bentley <aaron.bentley at utoronto.ca <mailto:aaron.bentley at utoronto.ca> > wrote:
 

Marius Kruger wrote:
 > On 1/17/07, *John Arbash Meinel* <john at arbash-meinel.com <mailto:john at arbash-meinel.com> 
 
 
> I attached a bundle to 'Highlight trailing white space'
 > its probably an ugly hack, but I like the result.
 
 Apparently, we also need "Contains leading tabs" :-)

done 
I realise it was a bit of a joke, but I did it any ways as it might obviously be useful.
It also gives a summary of new lines containing tabs (if any).
  
 I like the idea, but I don't like having two different tests for
 trailing whitespace.  Don't Repeat Yourself, as Martin recently reminded me.

I tried to do this better, 
but that forced me to send the match object to colorstring(), or pass the components seperately.
 The colorstring() is not a nice api any more, so I was thinking
to change mine to _colorstring() and bring back the original one (for in case someone used it elsewhere).

 

 > We can also highlight text which is over 79 chars...
 > what do you think?
 
 David Allouche actually had a neat one for this.  Instead of "trailing
 whitespace" or "under 80 chars", he did "wraps idempotently".
 I'm not sure what you mean by "wraps idempotently", 
but my new version highlight long lines nicely.
 
regards
marius