[MERGE/1.4 only] Back out transaction cache removal.

[Robert Collins]

On Thu, 2008-04-17 at 16:18 -0500, John Arbash Meinel wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Robert Collins wrote:
> | This should be merged to 1.4 but not to mainline, and if 1.4 were merged
> | to mainline, cherry picked out from the merge so it doesn't apply.
> |
> | It reinstates the transaction cache which caused the performance hit
> | with knits, while I expected some fallout too much has occured and we
> | shouldn't need to delay the release to track them all down.
> |
> | -Rob
> |
> 
> I personally approve for 1.4, but would like to understand what you think a
> reasonable approach is for bzr.dev and 1.5.

We've had good success with other areas of the code in
reducing/eliminating caches e.g. by using 'iter_revisions' rather than
for rev in rev_ids:
   get_revision(rev)

I don't know that this is enough on its own, we may need to explicitly
cache the revision, inventory and signature knits within locks; this can
be done more simply than with transactions if we do decide thats the
right way.

-Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080418/ffbbbc0a/attachment.pgp