Bazaar fails with http transport on some servers

[Vincent Ladeuil]

>>>>> "john" == John Arbash Meinel <john at arbash-meinel.com> writes:

    john> Robert Collins wrote:
    >> On Mon, 2008-04-14 at 15:17 -0400, Aaron Bentley wrote:
    >>> -----BEGIN PGP SIGNED MESSAGE-----
    >>> Hash: SHA1
    >>> 
    >>> Thomas Christensen wrote:
    >>>> I was asked by Stefan to investigate where is the bug: at savannah or
    >>>> in bzr.  What do you think?
    >>> I am inclined to think the bug is in Bazaar.
    >>> 
    >>> If they were returning 403 for a GET, that would be unreasonable-- they
    >>> shouldn't be choosing which files are permitted in .bzr.
    >>> 
    >>> However, a GET of
    >>> http://arch.sv.gnu.org/archives/emacs/bzr/emacs.app/.bzr/smart produces
    >>> a 404, as it should.
    >>> 
    >>> So it seems they're refusing the request because it is a POST request,
    >>> and this is their prerogative; Bazaar should not require POST in order
    >>> to fetch from plain http servers, just GET and HEAD.  Technically, they
    >>> should be replying with 405, IIUC.
    >>> 
    >>> I think Bazaar needs to accept a wide range of failures when determining
    >>> whether the smart server is supported.  At least 403, 404, 405, 410.
    >>> Possibly 500, 501, 503 as well (i.e. fallback to dumb operations if the
    >>> smart server is broken).   But when doing normal operations, it should
    >>> not use this broader list.
    >> 
    >> Full ack. 403 is ok-but-strange here.
    >> 
    >> bb:approve on the original patch, though a test would be ideal.

bb:approve

Aaron*,  was that vote taken into account ? If not, we investigated
that it was triggered by the unusual (but legal) 'Reply-To' header
produced by gnus.

    >> 
    >> -Rob

    john> Vincent, does your HTTP stuff have a way to give a canned 403 response so we
    john> could test it?

bzrlib.tests.test_http.ForbiddenRequestHandler should be a good
base. Leave me a couple of days to process my huge backlog and I'll
write the needed tests.

If this should be merged urgently, please do so, I'll submit a patch
with the tests ASAP.

     Vincent

*: I've seen your mail regarding working on BB, but I don't know
 if this is in the scope.