Bazaar fails with http transport on some servers

[Thomas Christensen]

Hi bazaar-ng

Stefan the maintainer of Emacs has set up a bzr repo on a GNU savannah
server.  When it is cloned with bzr.dev (1.4dev) it fails like this:

    $ bzr clone http://arch.sv.gnu.org/archives/emacs/bzr/emacs.app
    bzr: ERROR: Transport error: Server refuses to fullfil the request

I found out that savannah returns 403 on a file called `smart' that
bzr requests.  By patching it with this patch:

=== modified file 'bzrlib/transport/http/_urllib2_wrappers.py'
--- bzrlib/transport/http/_urllib2_wrappers.py	2008-03-17 19:53:19 +0000
+++ bzrlib/transport/http/_urllib2_wrappers.py	2008-04-13 00:52:26 +0000
@@ -1305,6 +1305,7 @@
 
     accepted_errors = [200, # Ok
                        206, # Partial content
+                       403, # Not found (or treat it as such for broken setups)
                        404, # Not found
                        ]
     """The error codes the caller will handle.

I managed to clone it.  This essentially treat it is a 404 I suppose.

I have tried cloning the repo with a vanilla bzr 1.3 as well -- no
problems there.

I was asked by Stefan to investigate where is the bug: at savannah or
in bzr.  What do you think?

		Thomas