Revision knit getting a line-delta

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I'm trying to debug some oddities that people are experiencing with 1.3.1 and
1.4.rc1.

They ran into a couple things...

1) "bzr merge" with 1.4rc1 was, for some reason, glacially slower. Specifically
they killed it after about 1hr of some random data downloading. After trying to
get it to work with 1.4rc1 a couple of times (killing it, breaking the lock,
trying again), they downgraded to 1.3.1 and got it to work.

2) Their central repository seems to be in knit format, though most of their
local ones are in --pack-0.92 format. I'm wondering if Robert's change to the
get_transaction() stuff is just brutally punishing people who use knit format
repositories anywhere. Because the Knit objects are no longer being cached, so
just doing a simple "iter_parents" sort of call has to download the full .kndx
file, parse it, throw it away, repeat for each revision they are looking at.

3) Somehow they managed to get a "line-delta" for one of the revision texts.
Which works in knits, but is explicitly prohibited in packs. (We had the policy
of always creating full-texts for revision texts, so it shouldn't really be
there, but it is, and it "broke" the branch.)


I'm wondering if Andrew's patch to "properly" handle line-delta's in the
serialization stream is actually introducing a false line-delta for the revision
texts.

Anyway, we need a way to get this repository back to "working". The first thing
is to just get the line-delta back to a full-text. but we need to make sure we
don't cause another line-delta to be generated.

Further, we seem to really be brutalizing knit performance in 1.4. Far worse
than I thought. Enough so that we either need to be spewing all over the place
that people need to upgrade, or revert some of the changes.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkgDjQAACgkQJdeBCYSNAAOPDACeJVYq4pjsl0Pz6lQ+DvSEKlge
694AnRiPjHWWLRuWEMU8E8uXKvBUJwLk
=n0zi
-----END PGP SIGNATURE-----