[Fwd: Re: [MERGE] "bzr commit" fails with Microsoft FTP Service]

[Alexander Belchenko]

FW to the list.

-------- Исходное сообщение --------
Тема: Re: [MERGE] "bzr commit" fails with Microsoft FTP Service
Дата: Fri, 11 Apr 2008 10:07:44 -0400
От: Aaron Bentley <aaron at aaronbentley.com>
Кому: Alexander Belchenko <bialix at ukr.net>
Ссылки: <ad8e2a1b0804080606q1d22297cpcd938db5bceeb38e at mail.gmail.com>	<47FC7446.30904 at arbash-meinel.com> 
<ad8e2a1b0804110455n1336c1a2meb10ae51cdaf03ab at mail.gmail.com> <47FF6EB7.9090904 at ukr.net>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Alexander Belchenko wrote:
> Andreas Deininger пишет:
>> 2008/4/9 John Arbash Meinel <john at arbash-meinel.com>:
>>> BB:tweak
>>>
>>> I don't think matching 550 anywhere in the string should be accepted.
>>> Instead we
>>> should probably do "if s.startswith('550')" or something similar.
>>>
>>> I don't know FTP well enough to know that for sure.
>>>
>>> Certainly our FTP error handling is a bit weak if they can send
>>> internationalized strings back to us. IIRC the error codes aren't
>>> particularly
>>> clear (you get a 550 for more than just file does not exist), which
>>> is why
>>> most
>>> of our code biases errors with the expected failure mode. (Creating a
>>> file
>>> likely doesn't have it's parent exist, renaming a file likely doesn't
>>> have
>>> the
>>> source exist, etc.)
>>>
>>> Anyway, if someone else knows FTP 550 better than I, I'm happy to have a
>>> .startswith() merged.
>>
>> After putting a the check for 550 in the _rename function, I'm
>> resubmitting that patch.
> 
> Just a thought: after error code 550 there should be a space usually?
> Should we check that fact too?

That would make sense.  Then you know it's 550, not 5500.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFH/3Cv0F+nu1YWqI0RApvZAJ40Pw2sxvo+owcyBgWeYu2sfiGt2ACfTh2D
66mzDww74W1stQPBU6OkQbg=
=4JXk
-----END PGP SIGNATURE-----