[PATCH] [Bug 209281] Re: Windows diff apps don't understand symlinks created by Cygwin bzr diff --using

[Martin Pool]

On Thu, Apr 10, 2008 at 7:52 AM, Aaron Bentley <aaron at aaronbentley.com> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
>  Hash: SHA1
>
>  Alexander Belchenko wrote:
>  > Aaron Bentley пишет:
>
> >> We shouldn't be repeating ourselves here.  Maybe
>  >> osutils.apps_support_symlinks
>  >
>  > I'm not sure it's good name. Cygwin indeed support symlinks. Even if
>  > native Windows application
>  > don't.
>
>  That's why I said "apps_support_symlinks"; on Cygwin, not all apps
>  support symlinks.  But it was only a suggestion.
>
>
>  > Is it really worth to introducing new UnavaliableFeature just to skip
>  > one test?
>
>  Most of our Features were added to support a small number of tests.
>  Some have expanded to support more, and some still support small number.

According to the developer guide, which was based on a fairly long
thread a while ago

UnavailableFeature
        The test can't be run because a dependency (typically a Python
        library) is not available in the test environment.  These
        are in general things that the person running the test could fix
        by installing the library.  It's OK if some of these occur when
        an end user runs the tests or if we're specifically testing in a
        limited environment, but a full test should never see them.

So it seems like not such a good fit as there is nothing people could
install to make symlinks work universally on Windows.

It seems to me we want to add class TestPlatformLimit(TestSkipped) to
tests/__init__.py and have it raise that.  (I realzie this is a bit
offtopic for Matt's patch so we could do it later...)

-- 
Martin <http://launchpad.net/~mbp/>