[MERGE] add a hook for Branch.set_last_revision_info()

Aaron Bentley aaron at aaronbentley.com
Wed Apr 9 13:05:28 BST 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

James Henstridge wrote:
>>  For myself, I'd prefer to invoke _make_branch_tip_hook_params after
>>  updating to the new revno and revision_id, since they're only
>>  *predicted* values at this point.

> Well, branch.last_revision_info() needs to be captured prior to
> updating the tip, so something needs to be done before hand.  I guess
> you're suggesting not to trust the method arguments for the new
> revno/revid?
> 
> I guess that makes sense, so I've changed the implementation to use
> last_revision_info() to determine both the old and new revision info.

I like the simplification that brings.

bb:approve

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFH/LEI0F+nu1YWqI0RAlYzAJ9dcGUhC7wMm4giNA2S2irv7mVqxgCfXnAp
dWhDgG+6PcmmZIDcYGpjBE0=
=1bCo
-----END PGP SIGNATURE-----



More information about the bazaar mailing list