[PATCH] [Bug 209281] Re: Windows diff apps don't understand symlinks created by Cygwin bzr diff --using

[Alexander Belchenko]

Aaron Bentley пишет:
> Matt McClure wrote:
>> On Sun, Apr 6, 2008 at 3:19 AM, Alexander Belchenko <bialix at ukr.net> wrote:
>>> Alexander Belchenko has voted tweak.
>>>  Status is now: Semi-approved
>>>  Comment:
>>>
>>> I'd like to see test_execute_windows_tool explicitly skipped on other platforms
>>> rather than silently succeeds.
>> See the attached tweaked patch.
> 
> bb:resubmit
> 
> I'd like to see this platform detection factored out into an osutils
> method.  We shouldn't be repeating ourselves here.  Maybe
> osutils.apps_support_symlinks

I'm not sure it's good name. Cygwin indeed support symlinks. Even if native Windows application
don't.

> 
>> +    def test_execute_windows_tool(self):
>> +        if (sys.platform != 'windows'
>> +            and sys.platform != 'cygwin'):
>> +            raise tests.TestSkipped('Platform does not have Windows tools.')
> 
> TestSkipped is rather generic.  We usually use UnavailableFeature (via
> our requireFeature code) to indicate platform differences.  Though the
> "feature" in this case is a deficiency, bringing new meaning to the
> phrase "it's not a bug, it's a feature".

Is it really worth to introducing new UnavaliableFeature just to skip one test?