[MERGE] "bzr commit" fails with Microsoft FTP Service

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Andrew Bennetts wrote:
> Aaron Bentley wrote:
>> Andrew Bennetts wrote:
>>> Andrew Bennetts has voted resubmit.
>>> Status is now: Resubmit
>>> Comment:
>>> I think it should be more like "s.startswith('550')".  The patch in its
>>> current form has a much too large chance of catching other errors.
>>>
>>> http://cr.yp.to/ftp/stor.html does say that a 550 response is expected,
>>> so this seems to be a correct thing to do.
>> I don't think it's correct to interpret 550 as rename failed.  There are
>> several other things that can cause it.  This is why we pay attention to
>> the strings, not the numerical codes.
> 
> Hmm, true.  I forgot that this is a generic error translator that doesn't know
> which request the error is for.
> 
> In that case, we should put a the check for 550 in the _rename function (or
> arrange for _translate_perm_error to know what the request was, but just putting
> it in _rename is probably simpler).

Yeah, for a protocol like FTP, we really need more context than
_translate_perm_error currently has.  But if we do improve the amount of
context, we should be able to wean ourselves off the dependency on
particular error strings.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFH/EfH0F+nu1YWqI0RAmy1AJ91AV4p7Zr4DBi45vosI/++T20kZQCeIeGo
McBhrcDCCFVuCziqpxohbps=
=atZt
-----END PGP SIGNATURE-----