[RFC] killing versioned file.join

Robert Collins robertc at robertcollins.net
Wed Apr 9 04:34:44 BST 2008


On Tue, 2008-04-08 at 23:28 -0400, Aaron Bentley wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Robert Collins wrote:
> > For same model fetches, we want the following:
> > knit->knit:
> >  * all text knit hunks, per versionedfile, topological order
> >  * ditto inventory
> >  * ditto signatures
> >  * ditto revisions
> > knit->pack:
> >  * as per knit->knit works fine
> > pack->knit:
> >  * as per knit->knit
> > pack->pack (occurs when fetching from a RemoteRepository only):
> >  * hunks from each pack, in forward-read IO order
> 
> > So - 
> > repository.get_data_stream_for_search(search, data_order,
> > complete_inventory)
> > data_order in ("read-optimal", "nonatomic-insert")
> > complete_inventory in (False, True)
> > 
> > is my proposed replacement API.
> > 
> > Thoughts? I plan to hack on this now, so an uncrafted reply now is
> > better than a crafted one tomorrow.
> 
> I'm left wondering what you plan to do about annotated/non-annotated
> file texts.

For both of these we can annotate/unannotate on the fly during
insertion.

The only constraint is that to annotate we need the unannotated texts in
topological order; the pack->knit case covers this, and the data_order
flag by requiring topological ordering meets this need.

-Rob


-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080409/f75e63cf/attachment.pgp 


More information about the bazaar mailing list