[merge][#109520] gc of LockableFiles should not warn or unlock

[Martin Pool]

I spoke to Robert a bit about this yesterday and we have a plan:

Garbage collection of a held lock should warn, but _not_ automatically
unlock.  So that's not at all sweeping it under the rug, which
reviewers disliked.

We should perhaps have a separate lock state of "dead" meaning we can
no longer access it (eg because of a transport error) therefore should
not complain about failures to unlock.

If people keep noticing this or other gc-related warnings in the test
suite after the deterministic lock check is fully implemented, we can
change it back to using temporary directory names based on the test
name to give more of a clue where it happened.  (We took it out
because it created overly long directory names on Windows but we could
at least put in an abbreviated form or just the method name, or
disable it on win32.)

-- 
Martin <http://launchpad.net/~mbp/>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 20080409-lock-warnings.diff
Type: text/x-diff
Size: 3467 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080409/5207e932/attachment.bin