[PATCH] [Bug 209281] Re: Windows diff apps don't understand symlinks created by Cygwin bzr diff --using

Matt McClure mlm at aya.yale.edu
Sat Apr 5 17:14:34 BST 2008


On Wed, Apr 2, 2008 at 12:31 AM, Martin Pool <mbp at canonical.com> wrote:
> On Wed, Apr 2, 2008 at 5:30 AM, Matt McClure <mlm at aya.yale.edu> wrote:
>  > Alexander suggested I move the conversation about bug 209281 from
>  >  Launchpad to this mailing list.  I've copied and pasted the most
>  >  recent comment from the bug report.  The patch itself is attached to
>  >  the report in Launchpad.
>
>  Thankyou for working with us to get a good patch for this.
>
>  Maybe at least as a first step _try_symlink_root should just be
>  changed to return False and not make symlinks on the Windows or Cygwin
>  platform?

Here's another attempt at a patch.  I also added a test that fails vs.
1.3 and succeeds vs. 1.3+patch.  Is there a better way to make the
test platform-dependent?

Matt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bug.209281.3.patch
Type: application/octet-stream
Size: 3550 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080405/2078e427/attachment.obj 


More information about the bazaar mailing list