[MERGE] nuke ``VersionedFile.create_empty``

[Robert Collins]

On Tue, 2008-04-01 at 15:01 +1000, Ian Clatworthy wrote:
> Robert Collins wrote:
> > This is a real problem for being able to stack things, so I'm not
> > deprecating, I'm removing.
> 
> bb:approve
> 
> My only concern here is the potential performance impact of
> 
>              for index, version in enumerate(order):
>                  pb.update('Converting versioned data', index, total)
> +                if version in target:
> +                    continue
> 
> For VersionFiles with many revisions (e.g. inventories on projects with
> deep history), this could suck. I'm not sure how often this default join
> logic gets triggered.
> 
> Is it worth pre-filtering the order list so the need for this test goes
> away? If so, that can come in another patch IMO.

This covers generic joins, e.g. knits to weaves. So - rarely.

-Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080402/e245f8db/attachment.pgp