[MERGE] Optimize revno calculation, revision-info and cat-revision
Andrew Bennetts
andrew at canonical.com
Mon Mar 31 08:13:01 BST 2008
Aaron Bentley wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hi all,
>
> This patch is a followon to my other patch for optimizing revision-id
> calculations, and optimizes revno calculations.
bb:tweak
I haven't looked at the branch this builds on, but this part looks good.
Just one comment:
[...]
> === modified file 'bzrlib/branch.py'
> --- bzrlib/branch.py 2008-03-30 17:28:19 +0000
> +++ bzrlib/branch.py 2008-03-31 03:45:32 +0000
> @@ -1871,8 +1871,8 @@
> self._extend_partial_history()
> return list(reversed(self._partial_revision_history_cache))
>
> - def _extend_partial_history(self, stop_index=None):
> - """Extend the partial history
> + def _extend_partial_history(self, stop_index=None, stop_revision=None):
> + """Extend the partial history to include a given index
>
> If a stop_index is supplied, stop when that index has been reached.
> Otherwise, stop when the beginning of history is reached.
> @@ -1892,6 +1892,8 @@
You ought to describe stop_revision in this docstring too.
-Andrew.
More information about the bazaar
mailing list