[MERGE] Speedup selftest by loading a previously saved test list

Robert Collins robertc at robertcollins.net
Mon Mar 31 02:25:43 BST 2008


On Fri, 2008-03-07 at 12:29 +0100, Vincent Ladeuil wrote:
> >>>>> "robert" == Robert Collins <robertc at robertcollins.net> writes:
> 
>     robert> On Tue, 2008-03-04 at 16:49 +0000, John Arbash Meinel wrote:
>     >> 
>     >> Overall this looks like a decent patch. I wonder if we shouldn't
>     >> continue to use test_suite() when possible and just have it thunk into
>     >> load_tests(...). I'm not sure if it is worthwhile as long as we keep
>     >> bzrlib.tests.test_suite().
> 
>     robert> I'd suggest trying for test_suite and if it is not there just user
>     robert> loader.load_tests_from_module(plugin)
> 
> Which is exactly the opposite of what I want to do ;-)
> 
> So, will it be ok if this was the default loader policy but I
> revert it when using a bzr specific loader activated via our
> specific selftest options ? I.e. when using --load-list the
> loader try load_tests first and then test_suite.

Just for the record - Vincent and I spoke in London about this; I
convinced him my proposal was sane and he's going to follow through on
it.

-Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080331/a965cf64/attachment.pgp 


More information about the bazaar mailing list