bzr send

[Martin Pool]

On Wed, Mar 26, 2008 at 4:41 PM, Aaron Bentley <aaron at aaronbentley.com> wrote:
>  > 1. support for a "in-reply-to" switch
>  > 2. support for MIME inlining
>  > 3. support multi mail-to (or cc)
>
>  To add the switches, you would edit bzrlib/builtins.py
>
>  You should add tests to bzrlib/tests/blackbox to make sure the new
>  switches work.

Specifically to test_send.py.

At present those test cases do not have very good support for testing
what is actually passed to the mail client, only how it's invoked.  I
think another patch in the queue does add a dummy client in there for
use in testing.

As far as adding the inline patch: it could be part of the standard
MailClient API that bzr can provide default content for the body of
the message.  Not everything will support this, but for those that do
it can be used for more than just putting the patch inline.  This
should be added in mail_client.py, and tested in test_mail_client.py.

>  The actual functionality would probably be implemented in
>  bzrlib/mail_client.py
>
>  Many mailers will not support inlining, so they'll need to raise a
>  specific error.  You would add that to bzrlib/errors.py.

I believe we only add specific errors for cases that enclosing code
might want to catch, and I'm not sure this would be in that category,
so raising a more generic MailClientError might be appropriate.

-- 
Martin <http://launchpad.net/~mbp/>