[MERGE] Speed up log --short / --line

Aaron Bentley aaron at aaronbentley.com
Mon Mar 24 21:18:53 GMT 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> On Mon, 2008-03-24 at 16:36 -0400, Aaron Bentley wrote:

>> This patch optimizes log operations, by providing a fast-path for
>> calculating view revisions when no merged revisions will be shown.  I've
>> written it as an alternative to Michael Hudson's cheaper-simple-logging
>> patch.
> 
> Ok, And it looks decent to me; however - you don't say anything about
> why your patch is preferrable, and I'm probably just missing context
> after easter :). 

One reason is that cheaper-simple-logging is slower than both bzr.dev
and fast-log when logging large numbers of revisions, and I did say that.

The other reason is code cleanliness; Michael didn't attempt any
refactoring, just made the existing _show_log function larger.  He also
reimplemented Repository.iter_reverse_revision_history.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFH6Bq90F+nu1YWqI0RAi72AJ9n70ogBMVwxKqzWeO5e61p9HXPogCdH97P
J8KEuv8UeBIHJ8+goVN7wgg=
=/ong
-----END PGP SIGNATURE-----



More information about the bazaar mailing list