[RFC] remove versioned_file.enable_cache

[Robert Collins]

On Mon, 2008-03-17 at 20:18 -0500, Ian Clatworthy wrote:
> John Arbash Meinel wrote:
> > Robert Collins wrote:
> >> the enable_cache method seems to be only called once, for knit repositor
> >> fetching. I think we can safely remove the cache logic entirely as packs
> >> are the default. (That or make the cache be a decorator/optional layer).
> 
> > So if you want to refactor it so that it is only enabled for Inventories
> > when fetching with Knit format repositories, I'm okay with that. But I
> > don't think we want such a significant regression on everyone who hasn't
> > upgraded yet.
> 
> I use vf.enable_cache() inside the fast-import plugin but just for the
> inventory knit. I can't remember the performance gain exactly but it was
> noticeable.

Sounds like you have a bug then; the cache in question would grow very
large and cause thrashing on big conversions. Oh wait, that happens
doesn't it :)

-Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080321/6f77d8d0/attachment.pgp