[merge][#109520] gc of LockableFiles should not warn or unlock

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:
> Martin Pool wrote:
> | Having thought this through, I actually want to take this one step
> | further and remove the unlock call from the del method.  Leaving
> | something locked is not so bad, trying to unlock when we may be
> | disconnected from the server causes knock-on failures, and in general
> | we try to avoid doing anything substantial from del methods.

> Well, I feel like sweeping it under the rug is hiding something which is
> broken
> in our test suite.

I feel the same.  It's an indication of programmer error.  Users should
in theory never see it.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFH4bj80F+nu1YWqI0RAioRAJ9LTv2OiH3w9CKIlLS3GVwPBi1SWACfT/IE
73j1Iowv1lGVUx6fhwqpevg=
=UFIh
-----END PGP SIGNATURE-----