[MERGE][BUG #77657] Give a nicer error for non fs_enc() paths
John Arbash Meinel
john at arbash-meinel.com
Tue Mar 18 18:47:22 GMT 2008
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Aaron Bentley wrote:
> John Arbash Meinel wrote:
>> Bug #77657 is about our inability to add paths that cannot be decoded in
>> the current FS encoding.
>
>> The attached patch just changes "iter_changes" to give a clear exception
>> about what file is causing the problems (which also removes the ugly
>> traceback.)
>
> bb:comment
>
> Couldn't this be applied to all working tree implementations? That
> would have a benefit for future formats.
>
> Aaron
Done.
It turned out to be pretty easy to implement for WT2 & 3, so I moved the
test into workingtree_implementations/*.
I thought about putting it into intertree_impl, because it is testing
"iter_changes". However only WTs will have the possibility of
non-unicode paths, because we just can't represent them in
RevisionTrees, etc.
John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFH4A46JdeBCYSNAAMRAoZeAJ9QKbxT+lcPyCppFAT1xL/aDGmjPACguLPF
4mDA/JxbFph1DtLSSxmSU0E=
=qBxI
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: non_utf8_77657.patch
Type: text/x-diff
Size: 18869 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080318/d02175cb/attachment.bin
More information about the bazaar
mailing list