[RFC] remove versioned_file.enable_cache

[Robert Collins]

On Mon, 2008-03-17 at 10:00 -0500, John Arbash Meinel wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Robert Collins wrote:
> > the enable_cache method seems to be only called once, for knit repositor
> > fetching. I think we can safely remove the cache logic entirely as packs
> > are the default. (That or make the cache be a decorator/optional layer).
> > 
> > -Rob
> 
> Specifically, it was used because we download inventories first, to
> figure out what texts we need to process. But we can't install the
> inventories in a Knit repository.
>
> If you remove this completely, it will significantly hurt Knit format
> fetching. Because it has to download the inventories 2x.
> 
> So if you want to refactor it so that it is only enabled for Inventories
> when fetching with Knit format repositories, I'm okay with that. But I
> don't think we want such a significant regression on everyone who hasn't
> upgraded yet.

Theres a bunch of cruft used to do the caching. I'll see if I can make
that cleaner, but given how badly knits scale anyway, I don't think that
it can possibly be considered a significant regression.

-Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080318/5b7d21e1/attachment.pgp