[MERGE] lookup revno by iterating history

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Aaron Bentley wrote:
> John Arbash Meinel wrote:
>> This time with patch. :)
> 
> The iter_reverse_revision_history code looks redundant with
> Branch._lefthand_history.  I realize that you're just updating an
> existing function, but can you try to unify them?
> 
> Aaron

I can try, but looking at it _lefthand_history() wants to re-use the
Graph object so it can check "is_ancestor". And I really don't want to
be grabbing 2 Graph objects unless we have the KnitPackRepository
sharing its CachingParentsProvider with all graph callers.

So if we decide to save the CachingParentsProvider then I can fairly
trivially merge the two. (Basically _lefthand_history just adds a
get_graph().is_ancestor() call, and then calls into iter_reverse...)

I suppose I could also allow passing in a Graph object to re-use, but as
it is a public Repository function, that starts breaking things for bzr-svn.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFH3ohuJdeBCYSNAAMRAlm4AKCFUAYf3p0rXY7bFxoXmDL5E/j4QgCgrjVX
OCSsI5GSoVnGSY0K7+Z4EmE=
=SBwA
-----END PGP SIGNATURE-----