[pqm-submit:MERGE] Remove default --message

[James Henstridge]

On 16/03/2008, John Arbash Meinel <john at arbash-meinel.com> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
>  Hash: SHA1
>
>  The existing pqm-submit plugin grabs the commit message from the last
>  commit on the branch. However, this is *rarely* appropriate for a merge
>  commit.

That fits in with my experience with pqm-submit, so no complaints from
me.  The last few commits on most of my branch are usually cleanups
related to reviewer comments and don't have log messages that
represent the primary purpose of the branch.

Furthermore, Launchpad's PQM requires messages in a form that doesn't
match most of my commit messages :)


>  It also adds another fix, which only allows a non-exact path when it is
>  using the '.' path.
>
>  The impetus for this was because Andrew just successfully did:
>
>  bzr pqm-submit "This is a nice long commit message"
>
>  However, it thought that was a filename in the current working tree, and
>  sent a message for the last commit on the branch.

That does seem like a bug.  So you're changing it to do open() rather
than open_containing() if a path is provided?


>  I didn't want to push this automatically without telling people, because
>  it does disallow 'bzr pqm-submit' with no -m/--message.

I'd say go ahead and do it.  If there are complaints, we could add an
option to use the last commit as the merge message (which users could
turn on by default with an alias if they want the old behaviour).

James.