KnitPackRepository isn't lazy about loading the pack names

John Arbash Meinel john at arbash-meinel.com
Sat Mar 15 14:40:41 GMT 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I just noticed this with my other tracing of what was going on for 'bzr
update'.

Specifically, every time you lock_read() a KnitPackRepository it goes
out and re-reads the pack names. The problem with this is that when we
lock a branch (say for getting last_revision_info()) it always locks the
repository. So even though the repository is never accessed, it still
has to read an extra file. That file is typically fairly small
(log(num_revisions) of lines). But it is still an extra probe.

Just something we might want to think about.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFH29/pJdeBCYSNAAMRAnMdAKCbgvbpVlNJA+mTCvKjtXZvzFuOLQCeLzFk
TEPlr8gd9sVRPVx9k7OOJDE=
=HgBL
-----END PGP SIGNATURE-----



More information about the bazaar mailing list