[MERGE] make "diff" detail property changes

James Westby jw+debian at jameswestby.net
Thu Mar 13 11:15:49 GMT 2008


On Thu, 2008-03-13 at 11:55 +0200, Alexander Belchenko wrote:
> James Westby пишет:
> > On Thu, 2008-03-13 at 08:41 +0200, Alexander Belchenko wrote:
> >> Chad пишет:
> >>> I couldn't add a new test to cover this code, as I don't know how to
> >>> make it portable (or excluded) for
> >>> Windows.
> >> bb:comment There is nothing is your patch anti-windoze. x-bit property
> >> is properly supported on Windows. And even with x-bit plugin I'm
> >> able to change it. So you don't need to skip such test on windows.
> > 
> > Hi Alexander,
> > 
> > For the test Chad needs to change the executable property on a file,
> > and then check that diff displays this change in the way that he wants.
> > 
> > There is no test that currently does this. Can you explain how to
> > change the property on a file on Windows please?
> 
> http://bazaar.launchpad.net/~bialix/bzr-x-bit/trunk/annotate/bialix%40ukr.net-20070328093543-blbtmf3k7jp6bmsd?file_id=__init__.py-20060516204016-5be79f11e31f2cb7
> 

Thanks Alexander, that's perfect.

Chad, do you understand how to make a test case using that to test
your changes?

Thanks,

James






More information about the bazaar mailing list