[MERGE][#139318] bzr send: ensure that command line to invoking mail client is 8-bit string, not unicode

Aaron Bentley aaron at aaronbentley.com
Wed Mar 12 00:59:08 GMT 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Alexander Belchenko wrote:
> OK, here is my better version so far.
> 
> Actually I should do conversion from unicode to 8bit string in different
> clients
> in different way, so John Meinel was right.
> 
> Now I moved encoding logic into _get_compose_commandline of each client,
> and test
> it for each client separately.
> 
> I hope it's finally *right* fix.

bb:tweak

This looks like a nice improvement.

The error message needs a "to" in it:
   _fmt = ('Unable to encode %(kind)s path %(path)r in '
           'user encoding %(user_encoding)s')

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFH1yrb0F+nu1YWqI0RAhr1AJ0ZyCxt1iDthzff6qGpIJBwwtRNtQCePhTG
1rRAeMi4OchxkUEdSLHkt30=
=Dn9Q
-----END PGP SIGNATURE-----



More information about the bazaar mailing list