[MERGE][Bug #64783] Fixing check to understand the split-up .bzr format

Daniel Mark Watkins D.M.Watkins at warwick.ac.uk
Mon Mar 10 23:56:32 GMT 2008


On Mon, 10 Mar 2008 16:18:22 -0400 (EDT)
John Arbash Meinel <john at arbash-meinel.com> wrote:
> <snip>
> ^- There are some oddities in this function. To start with, we almost 
> always try Tree then Branch then Repository. And we would typically
> do something like:
> <snip>
Done.

> Also, you are trying WT.open() but Branch.open_containing().
> If anything, what you want is WT.open_containing() and Branch.open().
> Personally, I think you only want open_containing() if path == '.'.
> But maybe that is just me.
Done.

> +def _check_working_tree(tree):
> 
> This should be rewritten to be WT.check(). The default implementation 
> can probably be what you have written.
I didn't write it, it was prior art in cmd_check before I started
working.  Regardless, it's now WT.check(). :)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: check.2.patch
Type: text/x-patch
Size: 25985 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080310/2ff9ce2c/attachment-0001.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080310/2ff9ce2c/attachment-0001.pgp 


More information about the bazaar mailing list