[MERGE][Bug #196618] Change some assertions to exceptions in LP plugin

James Westby jw+debian at jameswestby.net
Mon Mar 10 21:40:53 GMT 2008


On Mon, 2008-03-10 at 15:49 -0400, John Arbash Meinel wrote:
> John Arbash Meinel has voted approve.
> Status is now: Semi-approved
> Comment:
> Can we get another reviewer? This is pretty trivial, so if we don't get 
> one (and I remember) I'll merge this in a couple of days.

Hi,

I'm not a reviewer, but the changes seem sane to me.

> +            raise errors.InvalidURL(path=path,
> +                                    extra="You must specify a product.")

My only quibble is that it is not only products you specify, you can
specify ~user/product/branch can't you.

However I think it is an improvement to have this in either way.

Thanks,

James





More information about the bazaar mailing list