[MERGE] Fix for the bzr+https URL issue

John Arbash Meinel john at arbash-meinel.com
Mon Mar 10 20:58:13 GMT 2008

John Arbash Meinel has voted tweak.
Status is now: Semi-approved
Well, it seems like a test should be failing if _remote_is_at_least_1_2 
is not present on  SmartClientMedium.

Specifically, get_data_stream_for_search explicitly depends on that 
attribute to be present. It doesn't use getattr() or any other 
indirection. Which means that ._remote... is a required field for 
anything returned from _client.get_smart_medium(), and 
HTTP.get_smart_medium() returns self.


a) I feel like we are missing a test that the attribute is available, 
since obviously get_data_stream_for_search() is incompatible with 
bzr+http without it.

b) I don't think you want to inherit from SmartClientStreamMedium since 
HTTPTransport isn't going to implement the _accept_bytes, _flush, etc. 

So I think your fix is reasonable, but I would really like some sort of 
test that Bazaar is actually able of connecting to a bzr+http server and 
talking to it. It may be outside of what Jeff is comfortable with. If 
so, he can tell that to Andrew. But obviously our testing is deficient 
and we need some work here.

For details, see: 

More information about the bazaar mailing list