[MERGE] Add Hooks.install_named_hook

John Arbash Meinel john at arbash-meinel.com
Mon Mar 10 19:00:29 GMT 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Daniel Mark Watkins wrote:
| On Mon, 10 Mar 2008 09:19:34 -0500
| John Arbash Meinel <john at arbash-meinel.com> wrote:
|> You can't submit something with DeprecationWarnings to PQM. It runs
|> with -Werror so those would all fail.
|>
|> There are 2 things to be done...
|>
|> 1) Tests that are directly testing a deprecated function should not
|> be removed, but be adapted to use something like
|> "TestCase.applyDeprecated". That way we can tell both that the
|> function is correctly deprecated, *and* that we haven't broken it.
|>
|> 2) Other places in the codebase should be switched over to the new
|> function so they don't trigger DeprecationWarning.
| Done and done.
|
|
| Dan
|
well, for my money

BB:approve

Now I just need you to go to all the plugins that use 'install_hook' and switch
them to use "install_named_hook" :)

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFH1YVNJdeBCYSNAAMRAn0aAJ0YljAOJUcFiMerq0Wu7kqy9vXIhQCgwEmY
UyQrkGQ4AS4T41zue9B03r4=
=gwdX
-----END PGP SIGNATURE-----



More information about the bazaar mailing list