[ANN/RFC] beta version of check EOL hook available

[Eugene Wee]

Hi,

The multiple file reporting feature seems to be working well as of 
revision 20, and I like it :)

I also welcome inclusion of this plugin into the core, but would it be 
better to rename the configuration file to .bzrcheckeol or even .bzreol?

The latter might prove useful if there is a converteol plugin in the 
future: if a user installs converteol instead of checkeol, conversion to 
the specified line-endings will be forced instead of aborting the commit 
if wrong line-endings are found.

Thanks,
Eugene Wee

Alexander Belchenko wrote:
> I want to point on latest version of checkeol plugin (Check EOL 
> pre-commit hook).
> 
> I'm implementing support for sectioned .checkeol, so now it's possible 
> to check
> for different line-endings style in the working tree. Thanks to Eugene Wee
> who helps me with ideas and some code.
> 
> I wrote some sort of README and INSTALL guide. Thanks to James Westby 
> for reading draft.
> 
> I'm create setup.py script for helping in system-wide install on 
> python-based version
> of Bazaar.
> 
> So now plugin have code, tests and documentation. What's next?
> 
> I agree with Ville Vanio who suggested to put such plugin into the core. 
> So I'd like to
> prepare merge request for inclusion checkeol plugin to 
> bzr.dev/bzrlib/plugins at the
> beginning of next week. Any objections?
> 
> Although bzr needs good solution for line-endings problem inside, I hope 
> such plugin
> will help some users during next months.
> 
> I'd like to ask any interested people to try this plugin out and give me 
> your feedback.
> I think it's better to slightly change behavior of checking function 
> when wrong
> line-ending found: if you want to commit 100 files with wrong 
> line-endings it's most
> likely you want to see list of all files with wrong line-endings. 
> Currently EOL hook
> raise error at first file with wrong EOL. I think it will be better to 
> show the list
> of all wrong files and only then break commit.
> 
> Any suggestions? Comments? Bug reports?
>