[MERGE] Command Not Found plugin db + functionality code

James Westby jw+debian at jameswestby.net
Wed Mar 5 23:36:17 GMT 2008


On Wed, 2008-03-05 at 17:45 +0000, Martin Albisetti wrote:
> On Tue, Mar 4, 2008 at 12:05 AM, James Westby <jw+debian at jameswestby.net> wrote:
> >  "Command not found" for the invalid one, and then whatever you have
> >  defined for the valid one.
> >
> >  The regex support could allow you to check that things like the plugin
> >  name and URL were in the message, without rigidly defining the format,
> >  however it may be just as much work.
> 
> Took a simpler approach which is to look for the URL within the output.
> I hope this addresses your concern, if not, I'll dive into more
> complex solutions like adding a new command to the DB dynamically just
> for the test, and comparing the exact string output.
> 

Hi Martin,

I think that should be efficient.

I'm not sure whether we also need to check that the invalid
command doesn't suggest something. We don't want to suggest
installing the rebase plugin for every typo in a command.

I don't think it's too important though.

Thanks,

James






More information about the bazaar mailing list