[MERGE] Speedup selftest by loading a previously saved test list
Vincent Ladeuil
v.ladeuil+lp at free.fr
Tue Mar 4 17:33:50 GMT 2008
>>>>> "john" == John Arbash Meinel <john at arbash-meinel.com> writes:
<snip/>
john> BB:comment
john> Overall this looks like a decent patch. I wonder if we shouldn't
john> continue to use test_suite() when possible and just have it thunk into
john> load_tests(...).
We can't. We want to share the loader and using test_suite (which
takes no parameter) makes it impossible.
john> I'm not sure if it is worthwhile as long as we keep
john> bzrlib.tests.test_suite().
john> I also wonder how broken we are relative to other test
john> suite runners,
Care to mention some ? But keep in mind, that this patch change
only the way we *load* the tests, not how we run them.
john>
john> but I don't see any direct indication of our test suite
john> not working for it, since we still have our topmost
john> .test_suite() call which is still returning TestSuite
john> objects, etc. So I don't think your patch would change
john> our compatibility in an direct sense.
Especially since test_suite() looks like a bzrism AFAIK.
Vincent
More information about the bazaar
mailing list