[MERGE][#139318] bzr send @ win32: ensure that command line to invoking Thunderbird is 8-bit string, not unicode (because subprocess does not understand non-ascii unicode)

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Alexander Belchenko wrote:
>> Also, please include a test case.
> 
> I don't understand how to test this issue. It's very specific issue
> related to behavior of standard subprocess.py module on Windows,
> that in turn depend on msvcrt.dll library. What kind of test you're
> have in mind?

You could test that none of the commandline arguments are unicode strings.

> I think it's better place for encoding, because I need to convert URL
> to attachment to plain string too. I'd like to rework my patch according
> to your suggestion.

Cool, thanks.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHxB0P0F+nu1YWqI0RArr2AJ4ybFJzmRuKy73NR5/2+0HpuVUsOACff7wN
4bIENMNVBE0N0euysmsyQ1I=
=jhpC
-----END PGP SIGNATURE-----