[MERGE][#139318] bzr send @ win32: ensure that command line to invoking Thunderbird is 8-bit string, not unicode (because subprocess does not understand non-ascii unicode)
aaron at aaronbentley.com
Tue Feb 26 14:07:11 GMT 2008
-----BEGIN PGP SIGNED MESSAGE-----
Alexander Belchenko wrote:
>> Also, please include a test case.
> I don't understand how to test this issue. It's very specific issue
> related to behavior of standard subprocess.py module on Windows,
> that in turn depend on msvcrt.dll library. What kind of test you're
> have in mind?
You could test that none of the commandline arguments are unicode strings.
> I think it's better place for encoding, because I need to convert URL
> to attachment to plain string too. I'd like to rework my patch according
> to your suggestion.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
More information about the bazaar