[MERGE] external_references repository patch.

[Martin Pool]

Martin Pool has voted tweak.
Status is now: Conditionally approved
Comment:
+    def do(self, path):
+        """try to find a repository from path upwards

pep8: Needs a capital and period, similarly for other methods.

+        :return: norepository or ok, relpath.
+        """
+        try:
+            path, rich_root, tree_ref, external_lookup = 
self._find(path)
+            return SuccessfulSmartServerResponse(
+                ('ok', path, rich_root, tree_ref, external_lookup))

The return doc is not consistent with the actual return code; similarly 
for the other method.

-    'BzrDir.find_repository', 'bzrlib.smart.bzrdir', 
'SmartServerRequestFindRepository')
+    'BzrDir.find_repository', 'bzrlib.smart.bzrdir', 
'SmartServerRequestFindRepositoryV1')
+request_handlers.register_lazy(

I think it would be clearer if you did not rename the existing method 
but rather left it corresponding to the one sent across the wire.

I think we agreed on the list previously that we'd document in the code 
when the methods were added, so please do that in the docstring or 
comment.

For details, see: 
http://bundlebuggy.aaronbentley.com/request/%3C1203394391.15574.85.camel%40lifeless-64%3E