[MERGE] Add simple Storage object

Robert Collins robertc at robertcollins.net
Mon Feb 11 21:28:29 GMT 2008


On Mon, 2008-02-11 at 08:47 -0500, Aaron Bentley wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 


> I think that it would improve our separation of concerns to make
> bytestream reconstruction independent of physical storage, i.e. by
> having a separate Builder object.  That object would need to query the
> build dependencies in the UnifiedByteStore, and retrieve the raw entries
> from it.  So I would want a consistent API, even if technically it does
> not have to be public.

I think it is already separated to a significant degree - in knit.py the
Access objects handle physical data retrieval, the Index objects allow
querying in an abstract fashion for the location and compression method
of a single component, and the KnitData object does object building.

But for something like Weaves its very hard to consider the compressed
texts separate things to be combined by a third party, and I don't think
the way we structure the code should encourage considering them to be
separate things.

-Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080212/f740c9de/attachment.pgp 


More information about the bazaar mailing list