[MERGE][1.2][#185394] Disconnect and reconnect the smart medium after getting "unknown method" error from server if a request body was sent.
John Arbash Meinel
john at arbash-meinel.com
Thu Feb 7 15:51:44 GMT 2008
-----BEGIN PGP SIGNED MESSAGE-----
Vincent Ladeuil wrote:
|>>>>> "martin" == Martin Pool <mbp at canonical.com> writes:
| martin> Martin Pool has voted tweak.
| martin> Status is now: Conditionally approved
| martin> Comment:
| martin> My biggest concern is the disruption to users who
| martin> enter their password on every reconnection.
| The connection sharing is there to *avoid* such situations, if it
| fails it's a high (critical even) status bug and should be fixed.
I think you misunderstand. We are forcibly dropping the connection and
reconnecting because the server on the far end cannot handle our request.
Specifically, the method we added a while ago included a body to the
message. When sending the request to an old server, the server reads the
header and replies with "I don't know this request", and then goes on to
read the body as the next request, rather than reading and discarding it.
So we drop the connection to clear it out, and then reconnect.
Andrew is working on an upgrade to the protocol to make the server
handle unknown requests in a cleaner way (his V3 proposal from a while ago.)
So I agree we don't really want to reconnect, but it is necessary in
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
More information about the bazaar