[MERGE] ``BZR_LOG=disable`` suppresses writing messages to .bzr.log.

[John Arbash Meinel]

Alexander Belchenko wrote:
> Ian Clatworthy пишет:
>> Alexander Belchenko wrote:
>>> Here is another version.
>>> $BZR_LOG used to specify path for .bzr.log.
>>> If $BZR_LOG is /dev/null (Linux) or NUL (Windows) we are suppress log.
>>
>> bb:tweak
>>
>> The approach and code are fine IMO.
>>
>> My only suggestion is that the one line of help added to
>> help_topics/__init__.py be expanded to 2 ala BZR_HOME. As the help
>> currently reads, a naive user might think that specifying /dev/null or
>> NUL suppresses the log, regardless of OS.
> 
> Here is final version of my patch, with blackbox tests for version command,
> and tweaked help topic. Also I follow suggestion to use /dev/null or NUL
> as real filenames. I hope their impact on performance is really negligible.
> 

You don't actually assert that 'my.bzr.log' actually contains the logged 
info, just that 'bzr --version' reports it.

I would like to see that ~/.bzr.log is empty/nonexistant and that 
my.bzr.log does contain data. I don't think we need to test that "NUL" 
doesn't. :)

BB:tweak

John
=:->