Error Message

John Arbash Meinel john at arbash-meinel.com
Mon Feb 4 19:49:11 GMT 2008


James Westby wrote:
> On Sat, 2008-02-02 at 10:59 +0000, James Westby wrote:
>> On Thu, 2008-01-31 at 18:44 +0000, Devin Rider wrote:
>>> AttributeError: 'NoneType' object has no attribute 'as_dict'
>> Hi,
>>
>> This indicates that the lockfile was empty. I am not sure what the
>> correct behaviour should be in that case.
>>
>> Is there a chance that anyone else was doing any operations on this
>> repository at the same time?
> 
> Devin has informed me off list that this was the result of terminating
> a previous push.
> 
> I still think a better error would be useful. Can anyone say whether
> doing that would cause any problems?
> 
> Thanks,
> 
> James

I still don't understand how the file could be empty. We create it in 
another directory, write to it, and then rename the directory into place.

When we go to clean up we rename the directory out of the way, and then 
delete it.

I would like to know what failure is happening that is allowing the file 
to exist as "held/info" and still be empty.

That said, I agree that we should have better handling when we get an 
illegal file. We just haven't run into it before because it really 
shouldn't be possible.

John
=:->




More information about the bazaar mailing list