[MERGE] Make pull --quiet more quiet. Fixes #185907.

[James Westby]

On Wed, 2008-01-30 at 14:01 -0500, Aaron Bentley wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> James Westby wrote:
> > On Tue, 2008-01-29 at 16:17 -0500, Aaron Bentley wrote:
> >> -----BEGIN PGP SIGNED MESSAGE-----
> >> Hash: SHA1
> >>
> >> James Westby wrote:
> >>> Hi John,
> >>>
> >>> Your wish is my command.
> >>>
> >>> Thanks,
> >> Personally, I think that the bug is that pull uses outf instead of note.
> >>
> >> pull isn't ls or status; its primary purpose is not to produce output,
> >> which is why you want to quieten it in the first place.  Also, update
> >> and branch both use note for this same kind of message.
> >>
> >> So I think note is quite appropriate for pull.
> > 
> > However my testing shows that note is still sent to the terminal when
> > --quiet is provided.
> 
> My testing shows otherwise:
> $ bzr update
> Tree is up to date at revision 5581.
> $ bzr update --quiet
> $
> 

Ok, allow me to be a little more precise. Removing the is_quiet test
and changing the print for a note() makes the testcase I wrote for
this fail. However it does change the behaviour in direct testing.
This implies to me that the act of blackbox testing removes this
aspect of the note() call.

Thanks,

James