[ANNOUNCE] bzr shell hooks plugin

[Jelmer Vernooij]

Hi Ian,

Ian Clatworthy wrote:
> Jelmer Vernooij wrote:
> > I've just published a simple plugin for Bazaar that allows specifying
> > shell scripts as hooks. 
> > 
> > The bzr branch is available at
> > http://people.samba.org/bzr/jelmer/bzr-shell-hooks/trunk
> 
> Hooray! Here are a few comments:
> 
> * the example in README says "echo" when you mean "foo.sh" I think
> * we ought to trap OSError explicitly for missing commands
> * maybe look in multiple config files, not just branch.conf?
Thanks, I'll look into fixing these bits.

> * we need to support multiple command line scripts per hook per
>   config file using the Hg approach of optional tagging, e.g.
> 
> [hooks]
> pre_commit = foo.sh
> pre_commit.also = bar.sh
IMHO this last bit isn't all that urgent. I'm actually quite surprised
we've been able to get away with not supporting shell hooks for so long.
I guess people always use hooks for really standard things like sending
commit emails or notifying cia.

> This has been on my TODO list for a few weeks now. Any objections if I
> migrate this functionality into the core and add these changes? (I'm
> happy to make the core implementation forwardly compatible with your
> code as best I can.)
Not at all :-)

Cheers,

Jelmer

-- 
Jelmer Vernooij <jelmer at samba.org> - http://samba.org/~jelmer/
Jabber: jelmer at jabber.fsfe.org