[MERGE] bzr.exe: move builtin plugins out of library.zip to directory 'plugins'

[Alexander Belchenko]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins пишет:
| On Mon, 2008-01-21 at 00:57 +0200, Alexander Belchenko wrote:
|> This patch finishes reorganization of built-in plugins support for bzr.exe
|> that I started before bzr 1.0.
|>
|> In my past experiments I found that loading builtin plugins from library.zip
|> is slower than from filesystem, because library.zip itself very big
|> file (>10MB) with many files inside.
|>
|> So I moved builtin plugins (launchpad and multiparent) to 'plugins' directory
|> that installed typically as C:\Program Files\Bazaar\plugins.
|> bzr.exe is always looking for plugins in this directory, *after* user
|> plugins directory (either $APPDATA\bazaar\2.0\plugins or $BZR_PLUGIN_PATH).
|>
|> Also I disable looking for plugins in library.zip, therefore it should reduce
|> plugins search time as well.
|>
|> Now builtin plugins resides in filesystem,
|> so user is able disable them, if needed.
|
| I think this is a bad idea; the plugins shipped with bzrlib are in
| lockstep with bzr itself, and having them separate on disk allows many
| opportunities for problems.

I don't think so.

| Can we not just have the search be fast because we know exactly how many
| plugins are in the .zip ?

Then builtin plugins should not be looking for and loaded dynamically in runtime
but instead should be already registered in the core.

Actually I think if you want to have something very tightly integrated with the core --
it should be in the core.


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHoABUzYr338mxwCURAsEQAJ4qw5szkPS5QFiFrCxiI7QjvOXusACeM/Jo
9zoccsdAHhguYNr9M+DnPTM=
=Sqkp
-----END PGP SIGNATURE-----