[MERGE][#123623] selftest pollutes /tmp

Aaron Bentley aaron at aaronbentley.com
Tue Jan 29 19:37:59 GMT 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Vincent Ladeuil wrote:
> Hi,
> 
> The attached patch fixes several leaks:
> 
> 1) skipped, known failure and not applicable tests were leaving
>    their logs behind.
> 
> 2) various tests were leaking some tmp dirs.
> 
> 3) TransformPreview objects were leaking their limbodir.
> 
> 
> (1) was the most itching for me.
> 
> Thanks to Aaron for his assistance in fixing (3) and reviewing a
> previous (incorrect while a bit funny) version of this patch ;)
> 
> To reviewers: if you feel (3) controversial, say so explicitly
> and I'll make another submission just for it so that this patch
> can be merged (pending approval of course).

I haven't read the whole thing, but please ensure that tt.finalize() is
invoked in a finally block.  I saw you missed doing that in builtins, at
least.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHn4CX0F+nu1YWqI0RAjzGAJ467pAMBxxvkNMv+uX4aOXvh7dGywCghBsS
AozrpYzbbXHlmtcxQQEATWs=
=nTiq
-----END PGP SIGNATURE-----



More information about the bazaar mailing list