bzr.dev <-> bzr.dev network api break

[Robert Collins]

On Wed, 2008-01-23 at 09:02 +1100, Andrew Bennetts wrote:
> Robert Collins wrote:
> > 
> > On Tue, 2008-01-22 at 08:31 +1100, Andrew Bennetts wrote:
> > 
> > 
> > > Well, dropping the connection is an option too, as I think I said in the
> > > original mail.  The bit you quoted was just what I thought we should do: given
> > > that we know that no non-VFS methods take request bodies in the current
> > > protocol, if we do a protocol bump at the same time as we introduce a method
> > > that does accept a request body, then we can use "if protocol < 2" as a shortcut
> > > to deciding if we should even try it in the first place.  And this would avoid
> > > dropping a connection, which would be nice.
> > 
> > Well, we already have methods that take request bodies and use protocol
> > 2. Which is why I think its problematic to use that shortcut: you'll
> > force an upgrade on the server/degrade performance.
> 
> Those methods are well-known (they are VFS methods, as I mentioned).  I wasn't
> proposing shortcutting those.

It was certainly confusing for me to have this implied exclusion on what
is and is not shurtcutted; I suggest that it is likely confusing for
anyone else hacking on the smart server code whereas the less clever
approach I suggested can be implemented consistently across all methods.

-Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080123/4c7e57ec/attachment.pgp