bzr.dev <-> bzr.dev network api break

[Robert Collins]

On Tue, 2008-01-22 at 08:31 +1100, Andrew Bennetts wrote:


> Well, dropping the connection is an option too, as I think I said in the
> original mail.  The bit you quoted was just what I thought we should do: given
> that we know that no non-VFS methods take request bodies in the current
> protocol, if we do a protocol bump at the same time as we introduce a method
> that does accept a request body, then we can use "if protocol < 2" as a shortcut
> to deciding if we should even try it in the first place.  And this would avoid
> dropping a connection, which would be nice.

Well, we already have methods that take request bodies and use protocol
2. Which is why I think its problematic to use that shortcut: you'll
force an upgrade on the server/degrade performance.

> Also, if protocol version 3 can safely handle unknown methods, even if they have
> request bodies, then with my approach we don't need any "drop the session" logic
> at all, except in the initial "protocol unknown" situation.

Well, as long as we never start with body uploads then sure, we can
cache the protocol version we saw and use that.

-Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080122/5a9007ca/attachment.pgp