[merge][#124153][#124849] clean up capturing logging from within tests

Martin Pool mbp at sourcefrog.net
Tue Jan 22 08:07:04 GMT 2008


 * remove some crufty globals from bzrlib.trace
 * enable_test_log and disable_test_log are now properly symmetric and
restore the previous state
 * ... except that they're deprecated for new names push_test_log and
pop_test_log
 * and this is one major step towards being able to test bzrlib from
under a normal TestRunner, and generally makes it cleaner as a library

With this, we still have debug messages going out direct to a file,
and everything else through logging.py.  Logging.py is a bit slow, but
now that most of our debug statments are guarded by a check of
debug_flags this may not be a big deal.  So later on, someone could
make them all go through logging.py, and there is scope for some more
cleanups.

-- 
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 20080122-test-kibble.diff
Type: text/x-patch
Size: 24957 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080122/badd1a3b/attachment-0001.bin 


More information about the bazaar mailing list