[MERGE] Improve test coverage, and fix a bug revealed by the improved coverage.

Andrew Bennetts andrew at canonical.com
Tue Jan 22 07:00:19 GMT 2008

While working on the smart server code I noticed a discrepancy between the tests
in TestSmartProtocolOne and TestSmartProtocolTwo.  I thought I'd pointed out
this particular discrepancy when reviewing the change that added it, but I guess
it got lost at some point.

I'm working on improving the tests so that the different protocol versions won't
accidentally have differing amounts of test coverage.  In the meantime, here's a
fix for the immediate problem.  It moves a test from TestSmartProtocolOne into
CommonSmartProtocolTestMixin, and fixes the bug in the protocol v2 code that
this reveals.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: bzr-mail-ATYRB0.patch
Type: text/x-diff
Size: 5594 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080122/f8643fc5/attachment.bin 

More information about the bazaar mailing list