'bzr pack' should sync and delete obsolete-packs/*

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> On Fri, 2008-01-18 at 11:56 -0600, John Arbash Meinel wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> I was just thinking about how 'bzr pack' rebuilds all of your pack
>> files, and creates a new slightly optimized pack file. Which is great,
>> but it means you instantly bloat your repository by 2x because you have
>> a copy of everything.
>>
>> I think it would be reasonable for the last steps of 'bzr pack' to be a
>> 'sync' call to flush everything to disk, and then delete everything in
>> .bzr/repository/obsolete-packs
>>
>> Does that seem reasonable?
> 
> Seems dangerous to me.
> 
> -Rob

Even after doing the sync? Considering we will delete them in a few
commits anyway, it would be nice if we didn't always have to double the
repository size when we think we want to optimize.

I suppose we could have it optional and supply a flag to enable it.

Do you have any specific concerns outside of sync not actually syncing
because of the specifics of hard-drive/OS level caching? We can't be
safe from that anyway.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHkSa6JdeBCYSNAAMRAhvjAJ9ZobXTQXDqeaZzU4u1pdzKdHHopwCgl5e/
hLCLrnm4vok+T4BLi5drZH0=
=waVR
-----END PGP SIGNATURE-----